> It's a subversion a standard trope.

There's nothing subversive.

> It's an ending about sacrifice that wouldn't make sense in any other context.

There are a million ways to make an ending about sacrifice. Rogue One chose the worst one, after a lot of other ridiculous choices